Skip to content

[fix][test] Run BlobStoreManagedLedgerOffloader* tests separately and reduce memory consumption#19009

Merged
lhotari merged 1 commit intoapache:masterfrom
lhotari:lh-fix-issue-with-other-tests-hanging
Dec 20, 2022
Merged

[fix][test] Run BlobStoreManagedLedgerOffloader* tests separately and reduce memory consumption#19009
lhotari merged 1 commit intoapache:masterfrom
lhotari:lh-fix-issue-with-other-tests-hanging

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Dec 20, 2022

Motivation

BlobStoreManagedLedgerOffloader* tests run out of memory and stall the "other" test run.

Modifications

  • fix excludes
  • run both BlobStoreManagedLedgerOffloaderTest and BlobStoreManagedLedgerOffloaderStreamingTest separately
  • clear the mocked bookkeeper between test methods

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: lhotari#116

@lhotari lhotari added this to the 2.12.0 milestone Dec 20, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 20, 2022
@lhotari
Copy link
Member Author

lhotari commented Dec 20, 2022

example from a heap dump

image

… reduce memory requirements

- fix excludes
- run both BlobStoreManagedLedgerOffloaderTest and BlobStoreManagedLedgerOffloaderStreamingTest separately
- clear mock bookkeeper ledgers between test methods
@lhotari lhotari force-pushed the lh-fix-issue-with-other-tests-hanging branch from 6df8cbe to 39aaf5e Compare December 20, 2022 15:00
@lhotari lhotari changed the title [fix][test] Increase heap memory for running BlobStoreManagedLedgerOffloader* tests and run separately [fix][test] Run BlobStoreManagedLedgerOffloader* tests separately and reduce memory consumption Dec 20, 2022
@lhotari
Copy link
Member Author

lhotari commented Dec 20, 2022

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #19009 (39aaf5e) into master (22866bd) will increase coverage by 1.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19009      +/-   ##
============================================
+ Coverage     45.92%   47.59%   +1.67%     
+ Complexity    10104     9467     -637     
============================================
  Files           680      626      -54     
  Lines         66758    59236    -7522     
  Branches       7147     6154     -993     
============================================
- Hits          30660    28196    -2464     
+ Misses        32680    28010    -4670     
+ Partials       3418     3030     -388     
Flag Coverage Δ
unittests 47.59% <ø> (+1.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../pulsar/broker/service/SharedConsumerAssignor.java 68.51% <0.00%> (-9.26%) ⬇️
...ction/buffer/impl/TransactionBufferClientImpl.java 76.74% <0.00%> (-4.66%) ⬇️
.../buffer/impl/TransactionBufferClientStatsImpl.java 82.00% <0.00%> (-4.00%) ⬇️
...pulsar/broker/TransactionMetadataStoreService.java 58.51% <0.00%> (-3.94%) ⬇️
...sar/broker/service/schema/SchemaRegistryStats.java 71.25% <0.00%> (-3.75%) ⬇️
...tion/buffer/impl/TransactionBufferHandlerImpl.java 50.00% <0.00%> (-2.54%) ⬇️
...ersistentStickyKeyDispatcherMultipleConsumers.java 58.33% <0.00%> (-1.97%) ⬇️
...tent/PersistentDispatcherSingleActiveConsumer.java 59.24% <0.00%> (-1.89%) ⬇️
.../pulsar/broker/service/BrokerServiceException.java 47.27% <0.00%> (-1.82%) ⬇️
...sar/broker/service/persistent/PersistentTopic.java 61.55% <0.00%> (-0.74%) ⬇️
... and 119 more

@lhotari lhotari merged commit 423bd84 into apache:master Dec 20, 2022
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Mar 19, 2025
… reduce memory consumption (apache#19009)

(cherry picked from commit 423bd84)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants