[fix][build] Improve the build and publish of pulsar images#20462
Closed
nodece wants to merge 2 commits intoapache:masterfrom
Closed
[fix][build] Improve the build and publish of pulsar images#20462nodece wants to merge 2 commits intoapache:masterfrom
nodece wants to merge 2 commits intoapache:masterfrom
Conversation
github-actions
bot
added
the
doc-required
Member
Author
|
/pulsarbot rerun-failure-checks |
nodece
force-pushed
the
improve-build-pulsar-images
branch
from
a5d0a37 to
c87fdd1
Compare
nodece
force-pushed
the
improve-build-pulsar-images
branch
from
c87fdd1 to
7b8488f
Compare
nodece
changed the title
nodece
force-pushed
the
improve-build-pulsar-images
branch
from
7b8488f to
14f07cd
Compare
4 tasks
nodece
requested review from
RobertIndie,
eolivelli,
lhotari,
merlimat,
michaeljmarshall and
tisonkun
jiazhai
reviewed
Jun 2, 2023
|
|
||
| # Trino writes logs to this directory (at least during tests), so we need to give the process permission | ||
| # to create those log directories. This should be removed when Trino is removed. | ||
| RUN chmod g+w /pulsar/trino |
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
improve-build-pulsar-images
branch
from
14f07cd to
6e89859
Compare
Member
|
Thanks for the help. overall lgtm. |
Member
Author
Thank @jiazhai for your review, let me research the publishing process in the CI. |
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
15 tasks
Member
Author
|
Waiting for #20435 into master, and then rebase this PR. |
|
The pr had no activity for 30 days, mark with Stale label. |
Member
Author
|
#20435 has resolved these issues and now closes this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses the following issues:
docker.organization, because we use hard-coded images in the Dockerfile, which always pulls images from theapachepulsarorganization.latesttag will be broken: [Bug] Latest docker image version should be 2.11.0 #19544.Modifications
ARG.${project.version}instead oflatest, if you want to build thelatesttag, please add-Dpulsar.latest.image.tag=latesttomvncommand.mvncommand to build and publish the images instead of thedockercommand.Documentation
docdoc-requireddoc-not-neededdoc-complete