[improve][build] add --no-cache-dir in dockerfile to disable the pip cache#20477
Merged
tisonkun merged 1 commit intoapache:masterfrom Jun 2, 2023
ericsyh:patch-1
Merged
[improve][build] add --no-cache-dir in dockerfile to disable the pip cache#20477tisonkun merged 1 commit intoapache:masterfrom ericsyh:patch-1
--no-cache-dir in dockerfile to disable the pip cache#20477tisonkun merged 1 commit intoapache:masterfrom
ericsyh:patch-1
Conversation
RobertIndie
approved these changes
Jun 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #20477 +/- ##
=========================================
Coverage 72.95% 72.96%
- Complexity 31914 31920 +6
=========================================
Files 1867 1867
Lines 138485 138523 +38
Branches 15202 15204 +2
=========================================
+ Hits 101037 101077 +40
+ Misses 29438 29431 -7
- Partials 8010 8015 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
--no-cache-dir in dockerfile to disable the pip cache--no-cache-dir in dockerfile to disable the pip cache
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Mar 19, 2025
…p cache (apache#20477) (cherry picked from commit ca00a83)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It's usually suggested to add
--no-cache-dirin dockerfile because PIP cache is useless in image and we can also reduce the image size by disabling the cache.Modifications
Add the
--no-cache-dirin dockerfile pip3 command.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: