[improve][fn] Avoid getting stats for a "regex" topic#22320
Open
jiangpengcheng wants to merge 1 commit intoapache:masterfrom
Open
[improve][fn] Avoid getting stats for a "regex" topic#22320jiangpengcheng wants to merge 1 commit intoapache:masterfrom
jiangpengcheng wants to merge 1 commit intoapache:masterfrom
Conversation
jiangpengcheng
force-pushed
the
fix_function_cleanup
branch
2 times, most recently
from
5123629 to
4f81abe
Compare
jiangpengcheng
force-pushed
the
fix_function_cleanup
branch
from
4f81abe to
4bc5dd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
While "cleanup" a function, it may try to get the stats for a "regex" topic which is useless, and the error logs also doesn't print the
existingConsumersModifications
Do not get stats if topic is "regex"
Verifying this change
Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: jiangpengcheng#29