Skip to content

[improve][fn] Avoid getting stats for a "regex" topic #22320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiangpengcheng wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[improve][fn] Avoid getting stats for a "regex" topic #22320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions ...r-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,24 +434,26 @@ private Supplier<Actions.ActionResult> getDeleteSubscriptionSupplier(
// for debugging purposes
List<Map<String, String>> existingConsumers = Collections.emptyList();
SubscriptionStats sub = null;
try {
TopicStats stats = pulsarAdmin.topics().getStats(topic);
sub = stats.getSubscriptions().get(subscriptionName);
if (sub != null) {
existingConsumers = sub.getConsumers().stream()
.map(consumerStats -> consumerStats.getMetadata())
.collect(Collectors.toList());
}
} catch (PulsarAdminException e1) {
if (!isRegex) {
try {
TopicStats stats = pulsarAdmin.topics().getStats(topic);
sub = stats.getSubscriptions().get(subscriptionName);
if (sub != null) {
existingConsumers = sub.getConsumers().stream()
.map(consumerStats -> consumerStats.getMetadata())
.collect(Collectors.toList());
}
} catch (PulsarAdminException e1) {

}
}

String errorMsg = e.getHttpError() != null ? e.getHttpError() : e.getMessage();
String finalErrorMsg;
if (sub != null) {
try {
finalErrorMsg = String.format("%s - existing consumers: %s",
errorMsg, ObjectMapperFactory.getMapper().writer().writeValueAsString(sub));
errorMsg, ObjectMapperFactory.getMapper().writer().writeValueAsString(existingConsumers));
} catch (JsonProcessingException jsonProcessingException) {
finalErrorMsg = errorMsg;
}
Expand Down