Fix Trigger Functionality - #2501
Merged
Merged
Conversation
Contributor
Author
|
run integration tests |
jerrypeng
approved these changes
Aug 31, 2018
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Sep 12, 2018
*Motivation* A BC issue was introduced by apache#2501. If a function is submitted by old CLI, which only containers topics to serde map. The new function worker will fail trigger request because it can't find input specs. ``` 17:28:32.105 [function-web-7-9] ERROR org.apache.pulsar.functions.worker.rest.api.FunctionsImpl - Function in trigger function has more than 1 input topics @ /public/default/ex ``` *Changes* The functions worker should handle BC. *Tests* No tests are added here. Since it requires a BC testing framework to be able to submit a function to a new functions worker by old CLI. Created apache#2569 for adding a BC testing framework to cover such BC issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When we moved to support schemas on functions, we moved away from customSerdeInputMap as the base structure for FunctionDetails, but rather went to inputSpecs. Some parts of the code weren't updated as part of that change. This pr fixes that.
Modifications
Describe the modifications you've done.
Result
After your change, what will change.