[improve][build] Build docker image only once when pushing #25194
+5
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When pushing images to Docker Hub, the
docker-maven-plugincurrently builds the image twice: once during thebuildgoal and again during thepushgoal. This results in redundant work and unnecessary build time.This change makes the Docker goal configurable so that the image is built only once when pushing.
Modifications
buildandpush) in the default execution of the Docker Maven plugin with the${docker.goal}property in bothdocker/pulsar/pom.xmlanddocker/pulsar-all/pom.xml, allowing the active goal to be configured.docker.goalproperty tobuildin the rootpom.xml, preserving the existing behavior for normal builds.docker.goal=pushproperty to thedocker-pushMaven profile in bothdocker/pulsar/pom.xmlanddocker/pulsar-all/pom.xml, so activating this profile pushes the image without triggering an extra build.Documentation
docdoc-requireddoc-not-neededdoc-complete