[fix][test] Fix flaky ReplicatorRateLimiterTest.testReplicatorRateLimiterMessageReceivedAllMessages#25340
Merged
lhotari merged 2 commits intoapache:masterfrom Mar 19, 2026
Conversation
…iterMessageReceivedAllMessages The AsyncTokenBucket rate limiter is not perfectly precise and can allow a small number of extra messages beyond the configured limit before throttling kicks in. Changed the assertion from requiring an exact count to verifying the rate limiter is effective (received at least the rate limit but not all messages).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25340 +/- ##
=============================================
+ Coverage 37.37% 72.72% +35.34%
- Complexity 13188 33853 +20665
=============================================
Files 1897 1954 +57
Lines 150557 154745 +4188
Branches 17215 17709 +494
=============================================
+ Hits 56276 112538 +56262
+ Misses 86612 33169 -53443
- Partials 7669 9038 +1369
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lhotari
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaky test failure
Summary
testReplicatorRateLimiterMessageReceivedAllMessageswhich asserts an exact message count (assertEquals(totalReceived, 100)) but theAsyncTokenBucketrate limiter can allow a small number of extra messages (e.g. 105) before throttling kicks in.Documentation
doc-not-needed(Your PR doesn't need any doc update)
Matching PR in forked repository
No response
Tip
Add the labels
ready-to-testandarea/testto trigger the CI.