Skip to content

[fix][test] Fix flaky ReplicatorRateLimiterTest.testReplicatorRateLimiterMessageReceivedAllMessages #25340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 2 commits into from
Mar 19, 2026
Merged

[fix][test] Fix flaky ReplicatorRateLimiterTest.testReplicatorRateLimiterMessageReceivedAllMessages #25340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2285ec0
[fix][test] Fix flaky ReplicatorRateLimiterTest.testReplicatorRateLim…
merlimat Mar 17, 2026
aa20f88
[fix][test] Use +/- 20% tolerance for rate limiter assertion
merlimat Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorRateLimiterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,12 @@ public void testReplicatorRateLimiterMessageReceivedAllMessages() throws Excepti
Awaitility.await().pollDelay(1, TimeUnit.SECONDS).untilAsserted(() -> {
log.info("Received message number: [{}]", totalReceived.get());

Assert.assertEquals(totalReceived.get(), messageRate);
// The rate limiter is not perfectly precise — allow +/- 20% tolerance.
int received = totalReceived.get();
Assert.assertTrue(received >= messageRate * 0.8,
"Should receive at least 80% of " + messageRate + " messages, got " + received);
Assert.assertTrue(received <= messageRate * 1.2,
"Should receive at most 120% of " + messageRate + " messages, got " + received);
});

consumer.close();
Expand Down
Loading