Skip to content

[fix][test] Fix flaky BrokerRegistryIntegrationTest port binding race #25463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodece merged 1 commit into from
Apr 7, 2026
Merged

[fix][test] Fix flaky BrokerRegistryIntegrationTest port binding race #25463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...t/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import java.util.List;
import java.util.Optional;
import lombok.extern.slf4j.Slf4j;
import org.apache.bookkeeper.util.PortManager;
import org.apache.pulsar.broker.PulsarService;
import org.apache.pulsar.broker.ServiceConfiguration;
import org.apache.pulsar.broker.loadbalance.LoadManager;
Expand All @@ -41,14 +40,14 @@
public class BrokerRegistryIntegrationTest {

private static final String clusterName = "test";
private final int zkPort = PortManager.nextFreePort();
private final LocalBookkeeperEnsemble bk = new LocalBookkeeperEnsemble(2, zkPort, PortManager::nextFreePort);
private LocalBookkeeperEnsemble bk;
private PulsarService pulsar;
private BrokerRegistry brokerRegistry;
private String brokerMetadataPath;

@BeforeClass
protected void setup() throws Exception {
bk = new LocalBookkeeperEnsemble(2, 0, () -> 0);
bk.start();
pulsar = new PulsarService(brokerConfig());
pulsar.start();
Expand All @@ -68,7 +67,9 @@ protected void cleanup() throws Exception {
pulsar.close();
}
final var elapsedMs = System.currentTimeMillis() - startMs;
bk.stop();
if (bk != null) {
bk.stop();
}
if (elapsedMs > 5000) {
throw new RuntimeException("Broker took " + elapsedMs + "ms to close");
}
Expand Down
Loading