[improve][client] Best-effort retry for individual/batch-index acks on send failure when ackReceiptEnabled=false#25525
Merged
Conversation
…ReceiptEnabled=false Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nodece
requested review from
codelipenghui,
dao-jun,
lhotari,
merlimat and
poorbarcode
Contributor
|
The final patch no longer restores cumulative grouped acknowledgements on local write failure, making the behavior a best-effort retry for only individual and batch-index acknowledgements. If this change is intentional, could we update the PR title and body accordingly? Otherwise, this branch still loses the retry opportunity for grouped cumulative acknowledgements when |
Denovo1998
approved these changes
Apr 23, 2026
nodece
changed the title
Member
Author
|
@Denovo1998 Both the title and body have been updated. We only retry for individual ack when |
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
May 6, 2026
…n send failure when ackReceiptEnabled=false (apache#25525) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When
ackReceiptEnabled=false, grouped consumer acks are sent in the background and local write failures could drop pending ack state. This increases the risk of ack holes that can block progress in cases likeKey_Sharedconsumption.Modifications
ackReceiptEnabled=false— applies to individual and batch-index acknowledgements onlyackReceiptEnabled=trueon explicit future/ack-receipt failure semantics instead of internal pending restore