[fix][broke] Fix ShadowReplicator source entry buffer leak#25732
Merged
nodece merged 2 commits intoMay 14, 2026
Conversation
ShadowReplicator deserializes source entries with an empty payload, so the producer send path does not own or release the source entry buffer. Remove the extra retain on headersAndPayload to let the send callback's Entry release fully release the buffer. Add a regression test that exercises the ShadowReplicator send path and verifies the source entry ByteBuf refCnt reaches zero after replication completes.
Contributor
Author
Contributor
Author
|
CI check pass in my local repo: https://github.com/void-ptr974/pulsar/actions/runs/25626436624 |
nodece
approved these changes
May 12, 2026
Contributor
|
@RobertIndie PTAL. Seems related to #23236 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #25257
Motivation
ShadowReplicatorwas retaining the source entryheadersAndPayloadbuffer before sending the replicated message. Unlike geo replication, shadow replication deserializes source entrieswith an empty payload, so the producer send path does not own or release the original source entry buffer.
This left one extra reference after the send callback released the
Entry, causing Netty leak detector reports like:LEAK: ByteBuf.release() was not calledChanges
headersAndPayload.retain()inShadowReplicator.ShadowReplicatorsend path and verifies the source entryByteBufrefCntreaches0after replication completes.Verification
Also verified the new test fails before the fix with expected [0] but found [1].
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes