[improve][fn] Standardize log4j2 Root logger configuration to use system property - #26121
Merged
Merged
Conversation
merlimat
approved these changes
Jun 30, 2026
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
@merlimat Please merge the PR if nothing else is required on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23783
Motivation
Both
java_instance_log4j2.xmlandkubernetes_instance_log4j2.xmlhad their Root logger levels hardcoded to 'info', which prevented thepulsar.log.levelsystem property from controlling the actual logging level. While the system property was defined in both files, it was only being applied at the AppenderRef level.Modifications
Updated both log4j2 configuration files in
pulsar-functions/runtime-all/src/main/resources/:<level>from hardcodedinfoto${sys:pulsar.log.level:-info}<level>attribute from the AppenderRef elementBoth files now consistently use the
${sys:pulsar.log.level}system property at the Root logger level, enabling proper dynamic log level control.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes