[improve][test] Cover reverse equality for topic message IDs - #26449
Merged
merlimat merged 1 commit intoSep 2, 2026
Merged
Conversation
merlimat
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
testBatchMessageIdImplCompareToTopicMessageIdrepeated the same reverse-order assertion, leaving the corresponding equality case unchecked.Modifications
Replace the duplicate assertion with a reverse comparison between the topic message ID and the equivalent batch message ID (
batchIndex = -1).Verifying this change
git diff --check./gradlew :pulsar-client-original:test -PtestRetryCount=0 --tests org.apache.pulsar.client.impl.MessageIdCompareToTestcould not start because this environment has no Java runtime.\n\n### Does this pull request potentially affect one of the following parts:\n\n- [ ] Dependencies (add or upgrade a dependency)\n- [ ] The public API\n- [ ] The schema\n- [ ] The default values of configurations\n- [ ] The threading model\n- [ ] The binary protocol\n- [ ] The REST endpoints\n- [ ] The admin CLI options\n- [ ] The metrics\n- [ ] Anything that affects deployment