Use individual netty-* artifacts instead of netty-all#3613
Merged
Conversation
Contributor
|
did you get change to run broker with this change? just want to make sure that we won't have any runtime exception here.. |
Contributor
Author
|
The integration tests job is using the docker images, which are built from the distribution tgz. Any jar missing at runtime will show up there. |
ivankelly
approved these changes
Feb 20, 2019
Member
|
I would suggest you double checking the runtime-all jar to make sure shading are done correctly. otherwise functions will be broken when running in process mode. |
merlimat
force-pushed
the
netty-individual-deps
branch
from
52614e5 to
80d017f
Compare
Contributor
Author
|
run java8 tests |
4 similar comments
Contributor
Author
|
run java8 tests |
Contributor
Author
|
run java8 tests |
Contributor
Author
|
run java8 tests |
Contributor
Author
|
run java8 tests |
merlimat
force-pushed
the
netty-individual-deps
branch
2 times, most recently
from
db1d9f5 to
79af8b8
Compare
Contributor
Author
|
run java8 tests |
Contributor
Author
|
run java8 tests |
merlimat
force-pushed
the
netty-individual-deps
branch
from
0ec1b68 to
158a853
Compare
Contributor
Author
|
run java8 tests |
cdbartholomew
pushed a commit
to cdbartholomew/pulsar
that referenced
this pull request
Nov 27, 2019
cdbartholomew
pushed a commit
to cdbartholomew/pulsar
that referenced
this pull request
Dec 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
All of Pulsar dependencies are using the individual dependencies instead of getting Netty-all. We should do the same to avoid doing the hacky exclusions stuff. This also reduces a bit the sizes of our shaded jars and dist file.