[Issue 5387] Update Netty version for improving memory usage#5464
Closed
equanz wants to merge 3 commits into
Closed
[Issue 5387] Update Netty version for improving memory usage#5464equanz wants to merge 3 commits into
equanz wants to merge 3 commits into
Conversation
aahmed-se
approved these changes
Oct 25, 2019
Contributor
|
https://mvnrepository.com/artifact/io.netty/netty-all/4.1.42.Final is the latest release why not just update to that. |
Contributor
Author
|
@aahmed-se As follow suggestion, I'll try to update to https://mvnrepository.com/artifact/io.netty/netty-all/4.1.42.Final. |
Contributor
Author
|
Please take another look. |
Contributor
Member
|
The netty version is already upgraded as part of #3613 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Want to improve memory usage to be able to create many PulsarClients and Consumers.
(Fix #5387)
Modifications
Update Netty version to
4.1.34.Finaland netty-tcnative-boringssl-static version to2.0.22.Final.In Netty community, memory increase issue(netty/netty#8814) was reported (at
4.1.32.Final). It was fixed by netty/netty#8825 (at4.1.34.Final).When I apply
4.1.34.Finalthen memory usage was decreased correctly.