Skip to content

[Issue 5387] Update Netty version for improving memory usage#5464

Closed
equanz wants to merge 3 commits into
apache:masterfrom
equanz:update_netty_version
Closed

[Issue 5387] Update Netty version for improving memory usage#5464
equanz wants to merge 3 commits into
apache:masterfrom
equanz:update_netty_version

Conversation

@equanz
Copy link
Copy Markdown
Contributor

@equanz equanz commented Oct 25, 2019

Motivation

Want to improve memory usage to be able to create many PulsarClients and Consumers.
(Fix #5387)

Modifications

Update Netty version to 4.1.34.Final and netty-tcnative-boringssl-static version to 2.0.22.Final.

In Netty community, memory increase issue(netty/netty#8814) was reported (at 4.1.32.Final). It was fixed by netty/netty#8825 (at 4.1.34.Final).

When I apply 4.1.34.Final then memory usage was decreased correctly.

@aahmed-se aahmed-se requested a review from jerrypeng October 25, 2019 08:18
@aahmed-se
Copy link
Copy Markdown
Contributor

https://mvnrepository.com/artifact/io.netty/netty-all/4.1.42.Final is the latest release why not just update to that.

@equanz
Copy link
Copy Markdown
Contributor Author

equanz commented Oct 25, 2019

@aahmed-se
Thank you for your review.
In netty/netty#8814 issue, problem occurred patch version update. So, update version chose just fixed one. Not for critical reason such as build failure.

As follow suggestion, I'll try to update to https://mvnrepository.com/artifact/io.netty/netty-all/4.1.42.Final.

@equanz
Copy link
Copy Markdown
Contributor Author

equanz commented Oct 25, 2019

Please take another look.

@equanz equanz requested a review from aahmed-se October 25, 2019 10:17
@merlimat
Copy link
Copy Markdown
Contributor

@equanz Great catch on correlating #5387 with the netty memory usage issue.

The netty upgrade is already part of #3613 which is also breaking down netty-all into individual modules.

@sijie
Copy link
Copy Markdown
Member

sijie commented Oct 27, 2019

The netty version is already upgraded as part of #3613

@sijie sijie closed this Oct 27, 2019
@equanz equanz deleted the update_netty_version branch April 20, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When I create many PulsarClients and Consumers, fail to resolve hostname

4 participants