Skip to content

Comments

[docs] Update the upgrade guide#4792

Merged
sijie merged 3 commits intoapache:masterfrom
Jennifer88huang-zz:upgrade
Jul 27, 2019
Merged

[docs] Update the upgrade guide#4792
sijie merged 3 commits intoapache:masterfrom
Jennifer88huang-zz:upgrade

Conversation

@Jennifer88huang-zz
Copy link
Contributor

Motivation

The original PR #4770 is merged before I could give some feedback, so I just create a new pull request.

Modifications

  1. Refine the structure, remove some unnecessary info currently. Thus it is displayed to users as a complete guide.
  2. Refine the language part, make it clear and concise.
  3. Though "upgrade ZooKeeper" is optional, could we add information for it? So users can decide whether they want to upgrade ZooKeeper. When they upgrade ZooKeeper, they know how to upgrade.

@Jennifer88huang-zz Jennifer88huang-zz requested a review from sijie July 24, 2019 10:35
@Jennifer88huang-zz Jennifer88huang-zz self-assigned this Jul 24, 2019
@Jennifer88huang-zz Jennifer88huang-zz added area/admin doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. component/website labels Jul 24, 2019
@Jennifer88huang-zz Jennifer88huang-zz added this to the 2.5.0 milestone Jul 24, 2019
@Jennifer88huang-zz
Copy link
Contributor Author

@sijie Could you please add the content for "Upgrade ZooKeeper (optional)" section? Thank you.

@Jennifer88huang-zz
Copy link
Contributor Author

Is there any update on this PR? Any issue, feel free to comment. Thank you.

Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennifer88huang I have added a section for zookeeper. PTAL

@Jennifer88huang-zz
Copy link
Contributor Author

@sijie Thank you very much for your content. I've added "Upgrade ZooKeeper" section. PTAL.

@sijie sijie merged commit bfe7275 into apache:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants