DISPATCH-1268 - Set cmake_minimum_required to VERSION 2.8.12#449
DISPATCH-1268 - Set cmake_minimum_required to VERSION 2.8.12#449jirkadanek merged 5 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
=========================================
- Coverage 86.84% 86.8% -0.05%
=========================================
Files 85 85
Lines 18746 18746
=========================================
- Hits 16280 16272 -8
- Misses 2466 2474 +8
Continue to review full report at Codecov.
|
|
I think this update is OK. The oldest downstream environment that I'm aware of is RHEL6, which appears to use cmake 2.8.12. |
|
All right, I'll try to find more useful stuff to improve, given 2.8.12 features can be used. |
kgiusti
left a comment
There was a problem hiding this comment.
I'm good with this.
Ubuntu Trusty has 2.8.12 and that's the oldest LTS that's still officially maintained.
|
I think this is as far as I am going to go at this point. There are still some tweaks in the original PR which I did not do here, so I might open new PR for that, but this PR seems to me has enough changes already. I can squash the commits if you'd like. |
|
I'll merge this later today if no one objects. Thanks. |
… will still be one single failure when running h2spec against the router (apache#449)
A lot of changes from PR #288 is compatible with CMake 2.8.12 and can therefore still be used by the project.
This PR contains only the first change, tocmake_minimum_requiredversion, to see if there is a chance to get it in.