Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISPATCH-1268 - Set cmake_minimum_required to VERSION 2.8.12 #449

merged 5 commits into from Mar 5, 2019


None yet
4 participants
Copy link

jdanekrh commented Feb 16, 2019

A lot of changes from PR #288 is compatible with CMake 2.8.12 and can therefore still be used by the project.

This PR contains only the first change, to cmake_minimum_required version, to see if there is a chance to get it in.

@jdanekrh jdanekrh marked this pull request as ready for review Feb 16, 2019


This comment has been minimized.

Copy link

codecov-io commented Feb 16, 2019

Codecov Report

Merging #449 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #449      +/-   ##
- Coverage   86.84%   86.8%   -0.05%     
  Files          85      85              
  Lines       18746   18746              
- Hits        16280   16272       -8     
- Misses       2466    2474       +8
Impacted Files Coverage Δ
src/container.c 77.4% <0%> (-0.76%) ⬇️
src/router_core/agent_link.c 63.84% <0%> (-0.57%) ⬇️
src/router_core/core_client_api.c 91.57% <0%> (-0.37%) ⬇️
src/parse.c 88.29% <0%> (-0.26%) ⬇️
src/router_core/route_tables.c 76.67% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9670ce2...7f41347. Read the comment docs.


This comment has been minimized.

Copy link

ted-ross commented Feb 18, 2019

I think this update is OK. The oldest downstream environment that I'm aware of is RHEL6, which appears to use cmake 2.8.12.


This comment has been minimized.

Copy link
Contributor Author

jdanekrh commented Feb 19, 2019

All right, I'll try to find more useful stuff to improve, given 2.8.12 features can be used.

Copy link

kgiusti left a comment

I'm good with this.
Ubuntu Trusty has 2.8.12 and that's the oldest LTS that's still officially maintained.

@jdanekrh jdanekrh force-pushed the jdanekrh:jd_cmake branch from db87a51 to 2fcc8f9 Feb 20, 2019


This comment has been minimized.

Copy link
Contributor Author

jdanekrh commented Feb 21, 2019

I think this is as far as I am going to go at this point. There are still some tweaks in the original PR which I did not do here, so I might open new PR for that, but this PR seems to me has enough changes already.

I can squash the commits if you'd like.


This comment has been minimized.

Copy link
Contributor Author

jdanekrh commented Mar 5, 2019

I'll merge this later today if no one objects. Thanks.

@jdanekrh jdanekrh merged commit 39c7fb3 into apache:master Mar 5, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed

@jdanekrh jdanekrh deleted the jdanekrh:jd_cmake branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.