Skip to content

DISPATCH-1268 - Set cmake_minimum_required to VERSION 2.8.12#449

Merged
jirkadanek merged 5 commits intoapache:masterfrom
jirkadanek:jd_cmake
Mar 5, 2019
Merged

DISPATCH-1268 - Set cmake_minimum_required to VERSION 2.8.12#449
jirkadanek merged 5 commits intoapache:masterfrom
jirkadanek:jd_cmake

Conversation

@jirkadanek
Copy link

@jirkadanek jirkadanek commented Feb 16, 2019

A lot of changes from PR #288 is compatible with CMake 2.8.12 and can therefore still be used by the project.

This PR contains only the first change, to cmake_minimum_required version, to see if there is a chance to get it in.

@jirkadanek jirkadanek marked this pull request as ready for review February 16, 2019 12:11
@codecov-io
Copy link

Codecov Report

Merging #449 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #449      +/-   ##
=========================================
- Coverage   86.84%   86.8%   -0.05%     
=========================================
  Files          85      85              
  Lines       18746   18746              
=========================================
- Hits        16280   16272       -8     
- Misses       2466    2474       +8
Impacted Files Coverage Δ
src/container.c 77.4% <0%> (-0.76%) ⬇️
src/router_core/agent_link.c 63.84% <0%> (-0.57%) ⬇️
src/router_core/core_client_api.c 91.57% <0%> (-0.37%) ⬇️
src/parse.c 88.29% <0%> (-0.26%) ⬇️
src/router_core/route_tables.c 76.67% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9670ce2...7f41347. Read the comment docs.

@ted-ross
Copy link
Member

I think this update is OK. The oldest downstream environment that I'm aware of is RHEL6, which appears to use cmake 2.8.12.

@jirkadanek
Copy link
Author

All right, I'll try to find more useful stuff to improve, given 2.8.12 features can be used.

Copy link
Contributor

@kgiusti kgiusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this.
Ubuntu Trusty has 2.8.12 and that's the oldest LTS that's still officially maintained.

@jirkadanek
Copy link
Author

I think this is as far as I am going to go at this point. There are still some tweaks in the original PR which I did not do here, so I might open new PR for that, but this PR seems to me has enough changes already.

I can squash the commits if you'd like.

@jirkadanek
Copy link
Author

I'll merge this later today if no one objects. Thanks.

@jirkadanek jirkadanek merged commit 39c7fb3 into apache:master Mar 5, 2019
@jirkadanek jirkadanek deleted the jd_cmake branch March 5, 2019 15:40
ChugR pushed a commit to ChugR/qpid-dispatch that referenced this pull request Oct 13, 2022
… will still be one single failure when running h2spec against the router (apache#449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments