PROTON-1326: update python setup.py to avoid using incompatible opens… #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm assuming you are proposing to check this in branching from the 0.17 release? (It's difficult to tell from the PR). Note that the CI builds both fail - you will want to check this isn't due to this change. |
Contributor
Author
|
The failures don't seem to be related - various test failures but not the python-tox tests (which rely on setup.py patched by this patch). Yes - I would have to create a 0.17.x branch from 0.17.0 tag for this commit. The github gui didn't allow me to create a pull request against a tag so this PR is against master as that's the best I can do. |
Member
|
@kgiusti I think this PR is now irrelevant - as 0.18 is out and supports openssl 1.0 and 1.1. Could you close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sl 1.1.0
Proposing this patch against 0.17.x to fix a problem in the python-qpid-proton pypi packages.
I don't think this requires another 0.17.x release since the change only relates to python packaging. I simply need to rebuild the python packages on pypi with this fix.