PROTON-2171: Add BUILD_EXAMPLES option, to optionally skip building examples #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks correct - I'm not surprised it's easy, but why do you want to achieve it? |
Contributor
Author
|
I am surprised. I had bad experience with CMake before. I want to fix PROTON-2171. The reason for the request is that building examples takes quite a lot of time, especially the C++ examples. Disabling everything that doesn't necessarily need to be built shortens compilation time needed, to get the libs. This option IMO makes sense for Dispatch CI, for example. It could save a few seconds of the compilation time. |
jiridanek
force-pushed
the
jd_2020_10_05-skip_examples
branch
from
81a7dd4 to
fdd3045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be working, but I'll want to test it more, if I forgot anything. It was suspiciously easy to accomplish.