Skip to content

Conversation

@Jmennius
Copy link
Contributor

@Jmennius Jmennius commented Apr 7, 2022

CMake variable names are case-sensitive and so -Dproactor doesn't work, fix that.

Also, rephrase the section a bit and mention packages required for libuv usage.

CMake variable names are case-sensitive and so `-Dproactor` doesn't work,
fix that.

Also, rephrase the section a bit and mention packages required
for libuv usage.

Signed-off-by: Ievgen Popovych <ievgenp@seetrue.ai>
@codecov-commenter
Copy link

Codecov Report

Merging #363 (c100bf3) into main (a920192) will increase coverage by 20.11%.
The diff coverage is n/a.

❗ Current head c100bf3 differs from pull request most recent head 0b81afb. Consider uploading reports for the commit 0b81afb to get more accurate results

@@             Coverage Diff             @@
##             main     #363       +/-   ##
===========================================
+ Coverage   68.24%   88.36%   +20.11%     
===========================================
  Files         367       47      -320     
  Lines       73285     2397    -70888     
===========================================
- Hits        50011     2118    -47893     
+ Misses      23274      279    -22995     
Impacted Files Coverage Δ
cpp/examples/direct_recv.cpp
cpp/src/reconnect_test.cpp
cpp/src/uuid.cpp
cpp/src/tracker.cpp
cpp/examples/simple_recv.cpp
cpp/src/value.cpp
cpp/src/connection_driver_test.cpp
cpp/examples/ssl.cpp
python/tests/proton_tests/handler.py
cpp/src/proactor_container_impl.cpp
... and 310 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a920192...0b81afb. Read the comment docs.

@astitcher astitcher merged commit afa48aa into apache:main Apr 7, 2022
@Jmennius Jmennius deleted the fix-improve-docs-libuv-usage branch March 1, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants