RANGER-5735: Improve authorization consistency across RoleREST endpoints - #1149
Open
vyommani wants to merge 2 commits into
Open
RANGER-5735: Improve authorization consistency across RoleREST endpoints#1149vyommani wants to merge 2 commits into
vyommani wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Hardens authorization handling in RoleREST for role read and role grant/revoke operations:
getRole(id) and getUserRoles(user) now verify the caller is authorized to view the requested role/user's role membership, instead of returning it unconditionally.
grantRole/revokeRole now always resolve the caller's group membership server-side; group membership supplied in the request is no longer trusted for authorization decisions, except when the caller has already been independently verified as a Ranger admin/service admin/service user acting on behalf of another user.
grantRole/revokeRole now also block sessions with the read-only Auditor role from performing role mutations, consistent with existing behavior in ServiceREST.
How was this patch tested?
Added/updated unit tests in TestRoleREST covering authorized and unauthorized access for getRole, getUserRoles, grantRole, and revokeRole, including group-membership-based authorization and the Auditor-block behavior. Verified manually against a running instance.