This repository was archived by the owner on Aug 4, 2022. It is now read-only.
[REEF-1077] Allow VortexWorker reports to report about more than a si…#729
Closed
afchung wants to merge 3 commits intoapache:masterfrom
Closed
[REEF-1077] Allow VortexWorker reports to report about more than a si…#729afchung wants to merge 3 commits intoapache:masterfrom
afchung wants to merge 3 commits intoapache:masterfrom
Conversation
…ngle Tasklet This addressed the issue by * Change the original WorkerReport to TaskletReport. * Allow WorkerReports to hold a List of TaskletReports. JIRA: [REEF-1077](https://issues.apache.org/jira/browse/REEF-1077)
Contributor
Author
|
@bgchun @yunseong @johnyangk Please have a look and let me know what you think. Thanks! |
Contributor
|
@afchung This looks good to me in general. But the tests failed due to a minor checkstyle violation. Could you fix it first? Thanks! |
Contributor
Author
|
@yunseong Fixed it. Please have another look. Thanks! |
Contributor
There was a problem hiding this comment.
nit: Some indents consist of tabs, whereas others are using spaces.
Contributor
|
@afchung I took another look. Again, this looks good (one of the tests fail, but not relevant to this change). I've left very minor comments. @bgchun @johnyangk Do you have any other comments? |
Contributor
Author
|
@yunseong Fixed, please have another look. Thanks! |
Contributor
|
@afchung This looks good. I will test and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ngle Tasklet
This addressed the issue by
JIRA:
REEF-1077