This repository was archived by the owner on Aug 4, 2022. It is now read-only.
[REEF-115] Pull NuGet version from lang/cs/pom.xml file.#93
Closed
tmajest wants to merge 5 commits intoapache:masterfrom
Microsoft-CISL:REEF-115
Closed
[REEF-115] Pull NuGet version from lang/cs/pom.xml file.#93tmajest wants to merge 5 commits intoapache:masterfrom Microsoft-CISL:REEF-115
tmajest wants to merge 5 commits intoapache:masterfrom
Microsoft-CISL:REEF-115
Conversation
tmajest
changed the title
|
Reef-pull-request-windows #124 SUCCESS |
|
Reef-pull-request-ubuntu #287 SUCCESS |
tmajest
changed the title
|
Reef-pull-request-windows #125 SUCCESS |
|
Reef-pull-request-ubuntu #288 SUCCESS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: [REEF-115]
Pull NuGet version from lang/cs/pom.xml file.
The Nuspec files for REEF projects live in each project directory. The Nuspec files reference other REEF projects and do not yet contain version information. Typically, you pass -Version [version] into the NuGet pack command to update version information in Nuspec files. However, this will only update the$version$ token for the package itself, not for all of dependencies in the dependencies list. This means we have to manually replace the $version$ token for each REEF project in the dependencies list in the project's nuspec file.
This fix will pull the Nuspec files into a temporary location /lang/cs/.nuget/nuspec, extract the version string from /lang/cs/pom.xml, and replace all$version$ tokens in the Nuspec files with the extracted version string. These finalized nuspec files are then used to create the NuGet packages.
The packages are then copied to /lang/cs/.nuget/packages, but can also be found under the project's corresponding directory under /lang/cs/bin.