Skip to content

the first version of high-level-pull-consumer#748

Closed
shendongsd wants to merge 6 commits into
apache:pull-consumerfrom
shendongsd:feature_pull_consumer
Closed

the first version of high-level-pull-consumer#748
shendongsd wants to merge 6 commits into
apache:pull-consumerfrom
shendongsd:feature_pull_consumer

Conversation

@shendongsd
Copy link
Copy Markdown

@shendongsd shendongsd commented Dec 2, 2021

What is the purpose of the change

(#738)

Brief changelog

the first version of high-level-pull-consumer, I have reused a lot of pushcousumer code, it feels a bit messy, do you need to refactor the code structure, submit it now, let’s see how to implement it later

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@shendongsd shendongsd closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants