Skip to content

fix: report partial consumer group batch deletion outcomes - #1085

Closed
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-consumer-batch-delete-outcomes-1084
Closed

fix: report partial consumer group batch deletion outcomes#1085
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-consumer-batch-delete-outcomes-1084

Conversation

@Aias00

@Aias00 Aias00 commented Aug 6, 2026

Copy link
Copy Markdown

Summary

  • continue deleting selected consumer groups after an individual deletion fails
  • return deleted and failed outcomes from the service layer
  • remove only successful rows and keep failed rows selected for retry

Closes #1084

Verification

  • npm test -- --run src/services/consumerService.batchDelete.test.ts src/pages/instance/__tests__/ConsumerPage.test.tsx
  • npm run lint
  • npm run build

Copilot AI lite review requested due to automatic review settings August 6, 2026 05:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good improvement — batch deletion now continues after individual failures and reports exact outcomes (deleted/failed). Failed groups stay selected for easy retry, and the warning message clearly shows partial success. Service layer test and UI integration test both cover the partial-failure scenario thoroughly.


Automated review by github-manager-bot

@Aias00
Aias00 force-pushed the fix/studio-consumer-batch-delete-outcomes-1084 branch from 49d2eb5 to 7937575 Compare August 7, 2026 08:11
@lizhimins

Copy link
Copy Markdown
Member

Closing: already covered by the consolidated UI fix PR #1234 (merged as 2fa5d78, which integrated #1170's partial batch-delete outcomes with the instance-scoped signature). Thanks for the contribution! / 关闭说明:批量删除部分失败透出已由 #1234(合入 SHA 2fa5d78,整合 #1170 并与 instance 作用域签名合并)覆盖。感谢贡献!

@lizhimins lizhimins closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants