Skip to content

fix: expose cluster discovery failures - #1099

Closed
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-cluster-discovery-error-semantics-1098
Closed

fix: expose cluster discovery failures#1099
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-cluster-discovery-error-semantics-1098

Conversation

@Aias00

@Aias00 Aias00 commented Aug 6, 2026

Copy link
Copy Markdown

Summary

  • return a structured upstream error when NameServer cluster discovery fails
  • preserve empty results for standalone startup and genuinely empty topology
  • add regression coverage for failed discovery

Closes #1098

Test

  • JAVA_HOME=$( /usr/libexec/java_home -v 21 ) PATH="$JAVA_HOME/bin:$PATH" mvn -Dtest=RocketMQClusterProviderTest test

Copilot AI lite review requested due to automatic review settings August 6, 2026 05:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Trivial change, looks good.


Automated review by github-manager-bot

@Aias00

Aias00 commented Aug 7, 2026

Copy link
Copy Markdown
Author

Superseded by #1097, which now hardens Broker Cluster runtime operations and NameServer discovery failure semantics.

@Aias00 Aias00 closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants