fix: harden Apache instance lifecycle and endpoint validation - #1185
Closed
Aias00 wants to merge 4 commits into
Closed
fix: harden Apache instance lifecycle and endpoint validation#1185Aias00 wants to merge 4 commits into
Aias00 wants to merge 4 commits into
Conversation
RockteMQ-AI
approved these changes
Aug 7, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Adds explicit release() method to MqAdminExtFactory for evicting cached admin clients when instances are updated (endpoint change) or deleted. Correctly checks if an endpoint is still referenced by another instance before releasing.
LGTM — well-structured resource management with thorough test coverage including shared endpoint scenarios.
Automated review by github-manager-bot
Aias00
changed the title
Aias00
force-pushed
the
fix/studio-admin-client-lifecycle-1184
branch
from
August 7, 2026 06:26
be4666a to
57f08e5
Compare
Aias00
force-pushed
the
fix/studio-admin-client-lifecycle-1184
branch
from
August 7, 2026 07:01
57f08e5 to
30f965f
Compare
Aias00
changed the title
lizhimins
pushed a commit
to Aias00/rocketmq-dashboard
that referenced
this pull request
Aug 7, 2026
…tial invalidation Consolidates apache#1185, apache#1213, apache#1225, apache#1236, apache#1238: release unused runtime AdminClients, normalize NameServer cache keys, align cache lifecycle, validate Apache instance endpoints and type before persistence, invalidate Aliyun clients after credential changes, expose unavailable cloud resource counts and check current resources before deleting an instance.
lizhimins
pushed a commit
that referenced
this pull request
Aug 7, 2026
…tics and asset loading (#1177) * feat: complete instance scoping for metadata mutations, message queries, producers and dashboard Consolidates #1112, #1120, #1162, #1166, #1177: route Apache Topic mutations, test messages, producer connections, message queries, dashboard data and metrics sources by the selected instance; scope metadata deletes to the current cluster; redirect unknown instance routes. * fix: harden instance lifecycle, runtime admin caches and cloud credential invalidation Consolidates #1185, #1213, #1225, #1236, #1238: release unused runtime AdminClients, normalize NameServer cache keys, align cache lifecycle, validate Apache instance endpoints and type before persistence, invalidate Aliyun clients after credential changes, expose unavailable cloud resource counts and check current resources before deleting an instance. * fix: harden runtime diagnostics, dashboard overview and async detail freshness Consolidates #1089, #1205, #1219, #1223, #1240: guard stale async detail responses (consumer groups, LiteTopic), coordinate group refreshes, remove unsupported group/subscription actions, surface unavailable broker runtime statistics/versions and cluster discovery failures, wire Broker Cluster restart, mark dashboard clusters warning on runtime failures, preserve TPS precision, reuse broker runtime snapshots, distinguish unavailable DLQ statistics, handle missing DLQ enqueue timestamps, stop stalled pull scans and report DLQ resend failures. * fix: harden bundled asset loading, metrics labels and defaults; docs quick start; align tests Consolidates #1122, #1123, #1200, #1217: decode Grafana dashboard assets as UTF-8, skip invalid Grafana assets and incomplete alert rules, bound Prometheus time-series labels, stop seeding demo resources by default and complete the Docker Compose quick start docs. Also aligns pre-existing tests with the integrated behaviors (required instance type, live resource counts on delete, long TPS fields, default dashboard cluster type).
Member
|
Consolidated into #1177 (merged into rocketmq-studio as f727341): this change was integrated together with the remaining batch of instance-scoping, lifecycle, runtime-diagnostic and asset-hardening fixes, adapted to the current architecture and verified with the full test suite. Thanks for the contribution! / 已并入 #1177（合入 rocketmq-studio，SHA f727341）：与其余 instance 作用域、生命周期、运行时诊断与资产加固修复合批整合，适配了当前架构并通过全量测试。感谢贡献！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1184
Closes #1194
Verification