fix(settings): validate Metrics data source authentication - #1390
Closed
Aias00 wants to merge 1 commit into
Closed
Conversation
RockteMQ-AI
reviewed
Aug 10, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR modifies 2 files (+44 -1). After reviewing the changes:
Review Notes
- Changes appear structurally sound
- No critical issues detected in the diff
- Recommend verifying test coverage for the modified paths
Automated review by github-manager-bot
lizhimins
force-pushed
the
rocketmq-studio
branch
2 times, most recently
from
August 10, 2026 06:45
269e228 to
d58b463
Compare
Signed-off-by: liuhy <liuhongyu@apache.org>
lizhimins
force-pushed
the
fix/studio-validate-metrics-auth-mode-1389
branch
from
August 10, 2026 09:07
493142b to
1d44273
Compare
Author
|
Superseded by #1474, which consolidates Metrics data source type and authentication validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1389
Summary
Verification