[ISSUE #2889] Deduplicate LiteTopic TTL extensions - #2896
Closed
yuluo-yx wants to merge 1 commit into
Closed
Conversation
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
RockteMQ-AI
approved these changes
Sep 1, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
[ISSUE #2889] Deduplicate LiteTopic TTL extensions
Clean fix with proper deduplication guard and regression test coverage. No blocking issues.
Automated review by github-manager-bot
Member
|
Closing after review: extending a LiteTopic TTL is an idempotent operation — a double-click merely repeats the same extension with no harmful side effect, so the in-flight guard here addresses a scenario that cannot cause real damage. To keep the mainline free of low-value changes we're passing on this one; the other in-flight guard PRs covering genuinely duplicable mutations were merged in the batch integration. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed\n\n- acquire a synchronous in-flight guard before extending a LiteTopic TTL\n- release the guard on success or failure\n- add a deferred-promise regression for two confirmations in the same render\n\n## Why\n\nThe modal loading state alone did not prevent duplicate write requests before React committed the disabled state.\n\n## Verification\n\n- npm test -- --run src/pages/studio/tests/LiteTopic.test.tsx\n- Prettier and ESLint on the two changed files (existing Fast Refresh warning only)\n- scope check: 2 files, 23 changed lines\n\nFixes #2889