Skip to content

[ISSUE #2889] Deduplicate LiteTopic TTL extensions - #2896

Closed
yuluo-yx wants to merge 1 commit into
apache:rocketmq-studiofrom
yuluo-yx:0901-yuluo-yx/fix-3
Closed

[ISSUE #2889] Deduplicate LiteTopic TTL extensions#2896
yuluo-yx wants to merge 1 commit into
apache:rocketmq-studiofrom
yuluo-yx:0901-yuluo-yx/fix-3

Conversation

@yuluo-yx

@yuluo-yx yuluo-yx commented Sep 1, 2026

Copy link
Copy Markdown
Member

What changed\n\n- acquire a synchronous in-flight guard before extending a LiteTopic TTL\n- release the guard on success or failure\n- add a deferred-promise regression for two confirmations in the same render\n\n## Why\n\nThe modal loading state alone did not prevent duplicate write requests before React committed the disabled state.\n\n## Verification\n\n- npm test -- --run src/pages/studio/tests/LiteTopic.test.tsx\n- Prettier and ESLint on the two changed files (existing Fast Refresh warning only)\n- scope check: 2 files, 23 changed lines\n\nFixes #2889

Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

[ISSUE #2889] Deduplicate LiteTopic TTL extensions

Clean fix with proper deduplication guard and regression test coverage. No blocking issues.


Automated review by github-manager-bot

@lizhimins

Copy link
Copy Markdown
Member

Closing after review: extending a LiteTopic TTL is an idempotent operation — a double-click merely repeats the same extension with no harmful side effect, so the in-flight guard here addresses a scenario that cannot cause real damage. To keep the mainline free of low-value changes we're passing on this one; the other in-flight guard PRs covering genuinely duplicable mutations were merged in the batch integration. Thanks for the contribution!

@lizhimins lizhimins closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants