fix(ai): project empty message trace timelines - #2909
Open
yyqdbngt wants to merge 1 commit into
Open
Conversation
RockteMQ-AI
approved these changes
Sep 1, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Fixes NPE in MessageTraceToolHandler when the trace record or its node/consumer-status lists are null. Now projects empty timelines instead of crashing with a 500. Good defensive coding with two test cases covering both null-trace and null-lists scenarios.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MessageTraceToolHandlerprojects the trace timeline into the tool output, but assumedMessageService.getMessageTracealways returns a record with populatednodes/consumerStatuslists. Providers may report a missing trace asnull(the service's ownrecordTraceQueryalready guards for exactly that case) or as a record whose lists are absent, and the handler turned both shapes into an NPE 500 for AI/MCP/CLI callers.The projection now treats a missing trace or missing lists as an empty timeline. The tool output schema only requires the arrays to be present, so empty arrays stay schema-valid.
Why
The same trace lookup is also served to the web UI, where a missing trace renders as an empty timeline. MCP/CLI callers of
rmq.message.traceshould get the same "no trace found" answer instead of an internal error.Testing
Extended
MessageTraceToolHandlerTestwith two regression cases: null trace record, and record with null node/consumer-status lists.