fix(acl): carry the ACL user whitelist through user upserts - #2928
Open
yyqdbngt wants to merge 1 commit into
Open
fix(acl): carry the ACL user whitelist through user upserts#2928yyqdbngt wants to merge 1 commit into
yyqdbngt wants to merge 1 commit into
Conversation
RockteMQ-AI
approved these changes
Sep 1, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Carries the ACL user whitelist through user upsert operations so it is not silently dropped. Good bug fix — prevents ACL configuration loss during user updates.
Findings
- [Info] The fix correctly preserves the whitelist field during the upsert path.
Suggestions
No blocking issues. Test coverage verifies the whitelist survives the round-trip.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whiteRemoteAddressinMybatisPlusAclRepository.toUserEntityso the generic user upsert path persists the whitelistsaveUserandreplaceUserWhy
toUserVOreadswhite_remote_addressfrom the row, buttoUserEntitynever wrote it back: every upsert through the genericsaveUser/replaceUserpath silently dropped the whitelist carried on the VO. The plain-access endpoint worked around this by building its entity manually, but any caller of the generic upsert with a set whitelist lost it without an error. ExistingupdateUserbehavior is unchanged because the merged VO carries a null whitelist and MyBatis-Plus omits null fields fromupdateById.Testing
cd server && mvn -q -Dtest=MybatisPlusAclRepositoryTest test— all tests pass, including the newsaveUserShouldPersistTheWhiteRemoteAddressandreplaceUserShouldCarryTheWhiteRemoteAddressIntoTheUpdatecd server && mvn -q -Dtest=AclServiceTest test— all tests pass (regression for the update flow)