fix(cloud): consolidate inventory pagination - #2956
Merged
lizhimins merged 3 commits intoSep 2, 2026
Merged
Conversation
This was referenced Sep 2, 2026
RockteMQ-AI
approved these changes
Sep 2, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Replaces hardcoded MAX_PAGES pagination limits with proper totalCount-based termination across Aliyun and Tencent cloud providers. Extracts common pagination helpers (hasFetchedAll, isLastRolePage, describeRoles) to reduce duplication. Fixes a real bug where large datasets would be silently truncated.
LGTM 👍
Automated review by github-manager-bot
(cherry picked from commit e0bcd31) Signed-off-by: liuhy <liuhongyu@apache.org>
Tencent Cloud exposes TotalCount for ACL roles and topic subscriptions, so Studio should not silently stop at the old 100-page inventory ceiling. Constraint: Preserve short-page termination when Tencent omits TotalCount. Rejected: Keep MAX_PAGES guard | it still truncates valid inventories beyond 10,000 records. Confidence: high Scope-risk: narrow Tested: JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -Dtest=TencentAclServiceTest,TencentInstanceProviderTest test Tested: JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -Dtest='org.apache.rocketmq.studio.provider.tencent.*Test' test Not-tested: Full mvn test is blocked by pre-existing origin/rocketmq-studio AlertSchemaMigrationTest failure: rmq_instance_message table not found. Signed-off-by: liuhy <liuhongyu@apache.org> (cherry picked from commit 712b6c6) Signed-off-by: liuhy <liuhongyu@apache.org>
Aliyun consumer group inventories must not stop at the legacy five-page cap when the OpenAPI response reports more data. Continue until totalCount is satisfied or the service returns a short page so counts, exports, and management screens see the full group set.\n\nConstraint: refreshed against origin/rocketmq-studio at 899561e.\nRejected: keep MAX_PAGES fallback | it still returns a successful partial inventory for known totals above 500.\nConfidence: high\nScope-risk: narrow\nTested: JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q -Dtest=AliyunInstanceProviderTest test; JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q test Signed-off-by: liuhy <liuhongyu@apache.org> (cherry picked from commit e59ac28) Signed-off-by: liuhy <liuhongyu@apache.org>
lizhimins
force-pushed
the
consolidate/studio-cloud-inventory-pagination
branch
from
September 2, 2026 07:03
af00959 to
0b4e8ca
Compare
This was referenced Sep 2, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the cloud inventory pagination fixes from #2684, #2610, and #2669 into one PR based on the current
rocketmq-studiobranch.Replaces #2684
Replaces #2610
Replaces #2669
Closes #2678
Closes #2609
Closes #2667
Changes
TotalCountor short-page termination instead of the old fixed 10,000-record ceiling.TotalCount, preserving short-page termination when the API omits totals.totalCountis satisfied or a short page is returned.Verification
JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q -Dtest=AliyunInstanceProviderTest,TencentCatalogServiceTest,TencentAclServiceTest,TencentInstanceProviderTest testJAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q -Dtest='org.apache.rocketmq.studio.provider.*.*Test' testJAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q -DskipTests compilegit diff --check origin/rocketmq-studio...HEADFull backend
mvn -q testwas also run. It currently fails on the existing baselineAlertSchemaMigrationTestissue:Table "rmq_instance_message" not foundwhileAlertSchemaMigrationaddsresult_snapshot; this PR does not touch that area.