fix(i18n): localize client connection load failure message - #2977
Open
yyqdbngt wants to merge 1 commit into
Open
fix(i18n): localize client connection load failure message#2977yyqdbngt wants to merge 1 commit into
yyqdbngt wants to merge 1 commit into
Conversation
RockteMQ-AI
approved these changes
Sep 2, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
LGTM. Clean i18n localization with proper translation keys and fallback handling.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Localize the last hard-coded string on the clients page (
cluster/clients.tsx):getLoadErrorMessageno longer returns a module-level hard-coded Chinese fallback; callers passt('cluster.clientsLoadFailed')insteadcluster.clientsLoadFailedzh/en key intranslations.tsWhy
The clients page was already
useLang()-wired, but the load-failure toast still fell back to hard-coded Chinese when the API returned no usable message, so the English UI showed Chinese.Testing
tsc --noEmit→ cleaneslinton changed files → 0 errors