fix(message): trim trace query parameters - #3110
Open
yyqdbngt wants to merge 1 commit into
Open
Conversation
RockteMQ-AI
reviewed
Sep 4, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Fix looks good. Consider adding test coverage.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trim trace query parameters before lookup:
getMessageTracenormalizesmsgId/topic/traceTopicandgetMessageTraceByKeynormalizeskey/topic/traceTopic(null-safe trim) before delegating to the admin lookups.Why
Padded identifiers/paste artifacts previously flowed into the broker-side topic/id lookups, producing empty traces or confusing failures for otherwise valid input.
Testing
mvn -f server/pom.xml -Dtest=RocketMQMessageProviderTest testpasses: 31/31 (existing suite; behavior unchanged for clean input).