Skip to content

fix(i18n): localize consumer group create and CSV import flows - #3193

Open
yyqdbngt wants to merge 1 commit into
apache:rocketmq-studiofrom
yyqdbngt:codex/yy-consumer-create-import-i18n
Open

fix(i18n): localize consumer group create and CSV import flows#3193
yyqdbngt wants to merge 1 commit into
apache:rocketmq-studiofrom
yyqdbngt:codex/yy-consumer-create-import-i18n

Conversation

@yyqdbngt

@yyqdbngt yyqdbngt commented Sep 5, 2026

Copy link
Copy Markdown

Summary

The consumer group page is being localized in slices (offset-reset done previously); this PR covers the create-group and CSV import flows.

Localized in instance/consumer.tsx:

  • Toolbar and modal titles (创建 Group), the create confirmation dialog (确认创建 / 将创建消费组 "{name}" / confirm & cancel) and the success toast (消费组 {name} 创建成功).
  • The create form: Group 名称 label/validation (required, name pattern, max-length with the limit interpolated), placeholder, 订阅模式 / 消费类型 radio groups (集群消费 / 广播消费), 最大重试次数, 订阅组类型 select (普通消息 / 顺序消息 / 延迟消息 / 事务消息) and the conditional 顺序类型 select (分区顺序 / 全局顺序) - reusing existing keys (consumer.name, consumer.subMode, consumer.subGroupType, consumer.maxRetry) where wording matches.
  • The CSV import flow: no-instance guard toast, parse failure, row statuses (成功 / 失败 / 无效 / 待导入) and the import rows table (行号 / Group 名称 / 状态 / 说明), all result toasts (imported / partial failures / all-failed / invalid rows skipped), the modal title with or without filename, ok/cancel (重试失败项 / 开始导入 / 关闭) and the three notice states (CSV 无法导入, invalid rows, import plan) with their shared field note.
  • 43 new consumer.* keys; zh byte-identical.

Why

Creating groups and bulk-importing from CSV are frequent operator tasks whose forms, validation and result feedback must follow the active language.

Testing

  • tsc --noEmit passes
  • eslint clean on the changed files
  • vitest run ConsumerPage - 29/29 tests pass

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — clean i18n localization. Translation keys are well-organized and component changes are focused.


Automated review by github-manager-bot

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — clean i18n localization.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants