fix(i18n): localize topic create flow - #3195
Open
yyqdbngt wants to merge 1 commit into
Open
Conversation
RockteMQ-AI
approved these changes
Sep 5, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
LGTM — clean i18n localization. Translation keys are well-organized and component changes are focused.
Automated review by github-manager-bot
RockteMQ-AI
approved these changes
Sep 5, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
LGTM — clean i18n localization.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The topic page is being localized in slices (send-message and list surfaces done previously); this PR covers the create-topic flow.
Localized in instance/topic.tsx:
labelKey/descKey(普通消息 / 顺序消息 / 延迟消息 / 事务消息 / LiteTopic and their long-form descriptions), resolved through the translator in the Segmented options and the dynamic helper text.Topic「{name}」创建成功- reusing the existing key) and failure fallback.topic.createTopic), create/cancel buttons, Topic 名称 label with required / name-pattern / max-length validation (length interpolated) and placeholder (reusingtopic.name,topic.topicNameRequired,topic.topicNamePlaceholder), 类型 select, 写队列数 / 读队列数 with the shared queue extra (reusingtopic.writeQueues/topic.readQueues/topic.queueExtra), 权限 radio group (读写 / 只读 / 只写 reusingtopic.permRW/topic.permRO/topic.permWO) and 备注 with its placeholder.topic.*keys; zh byte-identical.Why
Topic creation drives a required flow with per-type guidance; forms and validation must read in the active language.
Testing
tsc --noEmitpasseseslintclean on the changed filesvitest run TopicPage- 21/21 tests pass