Skip to content

fix(i18n): localize topic create flow - #3195

Open
yyqdbngt wants to merge 1 commit into
apache:rocketmq-studiofrom
yyqdbngt:codex/yy-topic-create-i18n
Open

fix(i18n): localize topic create flow#3195
yyqdbngt wants to merge 1 commit into
apache:rocketmq-studiofrom
yyqdbngt:codex/yy-topic-create-i18n

Conversation

@yyqdbngt

@yyqdbngt yyqdbngt commented Sep 5, 2026

Copy link
Copy Markdown

Summary

The topic page is being localized in slices (send-message and list surfaces done previously); this PR covers the create-topic flow.

Localized in instance/topic.tsx:

  • The topic-type picker cards now carry labelKey / descKey (普通消息 / 顺序消息 / 延迟消息 / 事务消息 / LiteTopic and their long-form descriptions), resolved through the translator in the Segmented options and the dynamic helper text.
  • Create handler feedback: no-instance guard, success toast (Topic「{name}」创建成功 - reusing the existing key) and failure fallback.
  • The create modal: title (reusing topic.createTopic), create/cancel buttons, Topic 名称 label with required / name-pattern / max-length validation (length interpolated) and placeholder (reusing topic.name, topic.topicNameRequired, topic.topicNamePlaceholder), 类型 select, 写队列数 / 读队列数 with the shared queue extra (reusing topic.writeQueues / topic.readQueues / topic.queueExtra), 权限 radio group (读写 / 只读 / 只写 reusing topic.permRW / topic.permRO / topic.permWO) and 备注 with its placeholder.
  • 14 new topic.* keys; zh byte-identical.

Why

Topic creation drives a required flow with per-type guidance; forms and validation must read in the active language.

Testing

  • tsc --noEmit passes
  • eslint clean on the changed files
  • vitest run TopicPage - 21/21 tests pass

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — clean i18n localization. Translation keys are well-organized and component changes are focused.


Automated review by github-manager-bot

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — clean i18n localization.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants