Skip to content

fix(i18n): localize broker cluster instance selector - #3239

Open
yyqdbngt wants to merge 1 commit into
apache:rocketmq-studiofrom
yyqdbngt:codex/yy-broker-cluster-i18n
Open

fix(i18n): localize broker cluster instance selector#3239
yyqdbngt wants to merge 1 commit into
apache:rocketmq-studiofrom
yyqdbngt:codex/yy-broker-cluster-i18n

Conversation

@yyqdbngt

@yyqdbngt yyqdbngt commented Sep 5, 2026

Copy link
Copy Markdown

Summary

The Studio BrokerCluster page toolbar instance selector still used hard-coded zh for its accessible name and placeholder.

Localized in pages/studio/BrokerCluster.tsx:

  • The select aria-label and placeholder (选择实例) now use the new brokerCluster.selectInstance key.
  • 1 new brokerCluster.* key; zh byte-identical.

Why

The toolbar selector is the primary instance switch on the page; its accessible name must follow the active language.

Testing

  • tsc --noEmit passes
  • eslint clean on the changed files

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Replaces hardcoded Chinese strings in BrokerCluster.tsx with i18n translation keys. Clean and straightforward fix.

LGTM — good catch on the missing i18n keys.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants