test(common): deepen SystemGroupFilter prefix-boundary coverage - #3265
Open
yyqdbngt wants to merge 1 commit into
Open
test(common): deepen SystemGroupFilter prefix-boundary coverage#3265yyqdbngt wants to merge 1 commit into
yyqdbngt wants to merge 1 commit into
Conversation
RockteMQ-AI
approved these changes
Sep 5, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
test(common): deepen SystemGroupFilter prefix-boundary coverage
Clean test coverage improvement. Tests are well-structured with proper assertions and edge case handling.
LGTM.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the existing
SystemGroupFilterTest(1 to 3 tests) to pin down the prefix-boundary contract of the system consumer-group filter.Added cases:
app_TOOLS_CONSUMER,xCID_SYS_custom,xCID_HOUSEKEEPING_x,orders-CID_RMQ_SYS_TRANS,yrmq_sys_custom,pre%RETRY%consumer,suffix_%DLQ%consumer);CID_SYS_,rmq_sys_,%RETRY%) and the canonical prefixed names are still recognized as system.Why
The filter hides system consumer groups from user-facing lists and dashboard counts; its prefix-boundary semantics (token must start the name) had no negative coverage.
Testing
mvn -B test -Dtest=SystemGroupFilterTest— 3/3 pass; checkstyle (validate) clean.