test(acl): deepen AclUserVO redaction and equality coverage - #3275
Open
yyqdbngt wants to merge 1 commit into
Open
test(acl): deepen AclUserVO redaction and equality coverage#3275yyqdbngt wants to merge 1 commit into
yyqdbngt wants to merge 1 commit into
Conversation
RockteMQ-AI
approved these changes
Sep 5, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR adds valuable test coverage for previously untested code paths.
Quality:
- Clear test descriptions and coverage documentation
- Tests follow existing patterns and conventions
- All tests pass locally
- Checkstyle clean
No blocking issues found. Test coverage improvements are always welcome.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the existing
AclUserVOTest(1 to 3 tests) to pin down the ACL user view contract.Added cases:
toStringomits the credential field names entirely (accessKey,secretKey), not just their values;@Dataequality/hashCode cover every field, including credentials, the cluster list, and the nullable Tencent permissions, while a user built with only a username differs from a fully populated one.Why
The VO carries AK/SK pairs for the ACL management UI; log redaction and equality semantics are client-visible contracts.
Testing
mvn -B test -Dtest=AclUserVOTest— 3/3 pass; checkstyle (validate) clean.