fix(client): use backend connection filters - #3294
Open
tju-yxq wants to merge 1 commit into
Open
Conversation
RockteMQ-AI
approved these changes
Sep 5, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR optimizes the Client Connections page by moving cluster and type filtering from client-side to server-side, improving performance for large deployments.
Key Changes:
- Sends
clusterIdandtypefilters to backend API instead of filtering in browser - Adds type filter dropdown (Producer/Consumer)
- Resets pagination when filters change
- Cluster selector now preserves all registry clusters (not just from current response)
- Statistics and exports now based on filtered backend response
Implementation Quality:
- Clean separation of concerns (filters sent as query params)
- Proper dependency array updates in useEffect/useMemo hooks
- Good test coverage for combined filter scenarios
- Maintains UX by preserving cluster options from registry
No blocking issues found. This is a solid performance optimization with proper implementation.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The Client Connections page now forwards the selected cluster and client type to the existing backend query parameters instead of loading every connection and filtering only in the browser.
clusterIdandtypewhen a concrete filter is selected;Why
On installations with many connections, the page could request and render the complete inventory even when an operator had selected a cluster or type. The displayed totals and exported data also depended on the client-side copy rather than the backend result. This makes the existing filters useful for large deployments and preserves the ability to switch back to another registered cluster after filtering.
Closes #3291
Validation
npm test -- ClientsPage.test.tsx --run— 19 tests passednpm run lint -- --quiet— 0 errors; 10 existing warnings remain elsewhere in the treenpm run build— passedgit diff --check— passedThe repository's CI status is not being described here; the validation above is from the local branch.