[ISSUE-3779][test] Deepen GlobalExceptionHandlerTest with 501/500/503/type-mismatch/unreadable-body branches - #3779
Open
yyqdbngt wants to merge 1 commit into
Conversation
…h/unreadable-body branches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The existing
GlobalExceptionHandlerTestcovers business, LLM-gateway, 404/405/406 mappings, but five handler branches were still unverified through the advice: unsupported operations, the generic catch-all, Prometheus failures, request-parameter type mismatches and unreadable request bodies.Changes
unsupportedOperationReturns501Envelope:UnsupportedOperationExceptionmaps to HTTP 501 with the exception message preserved.unexpectedExceptionReturns500Envelope: the catch-all maps arbitrary runtime failures to HTTP 500 with the neutralInternal Server Errormessage (no leak).prometheusExceptionPreservesStatusAndMessage: a Prometheus failure keeps its status code and message.typeMismatchParameterReturns400InvalidParameter: a non-numeric path variable for anintparameter is reported as 400 with the generic parameter message.unreadableBodyReturns400InvalidBody: a malformed JSON body is reported as 400 with theInvalid request bodymessage.Verification