test: expand data source API coverage - #3885
Open
yyqdbngt wants to merge 1 commit into
Open
Conversation
RockteMQ-AI
approved these changes
Sep 6, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Expands data source API test coverage from 3 to 7 cases — adds authenticated/bearer token test paths, early pagination termination, and max-page guard.
LGTM — thorough coverage of pagination edge cases and auth forwarding.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The data source API tests covered the happy paths of load/create/update, the multi-page export, and delete/test basics, but left authenticated connections, bearer tokens, short last pages, and the max-page guard untested. This PR grows the suite from 3 to 7 cases.
Changes
testDataSourceforwardsusername/passwordfor basic-auth sources andbearerTokenfor token-auth sources.listAllDataSourcesstops early when the last page comes back short (fewer items than the declared total).listAllDataSourcesthrowsData source export exceeded 100 pageswhen pages keep returning full inventories.Verification
vitest run src/api/settings.test.ts: 7/7 passedtsc --noEmit: cleaneslint src/api/settings.test.ts: clean