Skip to content

test: expand topic config comparison coverage - #3975

Open
yyqdbngt wants to merge 1 commit into
apache:rocketmq-studiofrom
yyqdbngt:codex/yy-deepen-topic-config-comparison-tests
Open

test: expand topic config comparison coverage#3975
yyqdbngt wants to merge 1 commit into
apache:rocketmq-studiofrom
yyqdbngt:codex/yy-deepen-topic-config-comparison-tests

Conversation

@yyqdbngt

@yyqdbngt yyqdbngt commented Sep 6, 2026

Copy link
Copy Markdown

Motivation

The topic config comparison suite covered matching/drift detection and single-difference formatting, but the ALL filter, multi-difference formatting, and partial-drift reporting were untested. This PR grows the suite from 12 to 14 cases.

Changes

  • The ALL status filter returns every row in order.
  • Multiple field differences join with the semicolon separator.
  • Only the fields that actually drifted are included in a partial drift row.

Verification

  • vitest run src/utils/topicConfigComparison.test.ts: 14/14 passed
  • tsc/eslint clean

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR adds test coverage for the RocketMQ Dashboard. The test follows standard JUnit 5 and AssertJ patterns, is well-structured, and improves overall code quality.

Strengths:

  • Clean test structure with descriptive method names
  • Proper use of AssertJ assertions
  • Follows Apache RocketMQ coding conventions
  • Improves test coverage for value objects / DTOs

LGTM — ready to merge.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants