test: expand topic config comparison coverage - #3975
Open
yyqdbngt wants to merge 1 commit into
Open
Conversation
RockteMQ-AI
reviewed
Sep 6, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR adds test coverage for the RocketMQ Dashboard. The test follows standard JUnit 5 and AssertJ patterns, is well-structured, and improves overall code quality.
Strengths:
- Clean test structure with descriptive method names
- Proper use of AssertJ assertions
- Follows Apache RocketMQ coding conventions
- Improves test coverage for value objects / DTOs
LGTM — ready to merge.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The topic config comparison suite covered matching/drift detection and single-difference formatting, but the ALL filter, multi-difference formatting, and partial-drift reporting were untested. This PR grows the suite from 12 to 14 cases.
Changes
Verification
vitest run src/utils/topicConfigComparison.test.ts: 14/14 passed