[ISSUE #410] Make CORS allowed origins configurable#414
Open
itxaiohanglover wants to merge 2 commits into
Open
[ISSUE #410] Make CORS allowed origins configurable#414itxaiohanglover wants to merge 2 commits into
itxaiohanglover wants to merge 2 commits into
Conversation
Replace hardcoded CORS origin (http://localhost:3003) with a configurable property rocketmq.config.corsAllowedOrigins. Supports comma-separated values for multiple origins. Defaults to http://localhost:3003 for backward compatibility.
Document the new CORS configuration property with default value.
itxaiohanglover
force-pushed
the
fix/cors-configurable-origins
branch
from
65096af to
7c5a61f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes #410
The CORS allowed origin was hardcoded to
http://localhost:3003inSecurityConfig.java, making it impossible to deploy in production environments with different frontend domains.Brief changelog
@Value("${rocketmq.config.corsAllowedOrigins:http://localhost:3003}")to make CORS origins configurablecorsAllowedOriginsproperty toapplication.ymlwith documentationVerifying this change
Set
rocketmq.config.corsAllowedOriginsinapplication.ymlto verify different origins are accepted.