Skip to content

[Studio] fix: validate alert rule updates - #575

Merged
lizhimins merged 1 commit into
apache:rocketmq-studiofrom
yx9o:dev-574
Jul 28, 2026
Merged

[Studio] fix: validate alert rule updates#575
lizhimins merged 1 commit into
apache:rocketmq-studiofrom
yx9o:dev-574

Conversation

@yx9o

@yx9o yx9o commented Jul 25, 2026

Copy link
Copy Markdown

What is the purpose of the change

Fixes #574 .

Prevent /api/alert-rules/update from returning an internal server error for missing IDs or creating new rules for blank and unknown IDs.

This complements #549, which validates alert rule toggle and delete request bodies; this change covers update semantics.

Brief changelog

  • Reject null and blank alert rule IDs with HTTP 400.
  • Reject unknown alert rule IDs with HTTP 404.
  • Atomically replace existing rules so update cannot create a missing rule.
  • Add service and repository regression tests.

@lizhimins
lizhimins force-pushed the rocketmq-studio branch 5 times, most recently from b1f151b to 434c2ea Compare July 28, 2026 11:40
@lizhimins
lizhimins merged commit dcb7695 into apache:rocketmq-studio Jul 28, 2026
3 checks passed
@yx9o
yx9o deleted the dev-574 branch July 28, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants