Skip to content

[Studio] fix: validate data source mutation keys - #718

Merged
lizhimins merged 1 commit into
apache:rocketmq-studiofrom
yx9o:dev-080103
Aug 3, 2026
Merged

[Studio] fix: validate data source mutation keys#718
lizhimins merged 1 commit into
apache:rocketmq-studiofrom
yx9o:dev-080103

Conversation

@yx9o

@yx9o yx9o commented Aug 1, 2026

Copy link
Copy Markdown

What is the purpose of the change

Prevent data source update and delete operations from returning incorrect responses when the data source key is missing or does not exist.

Brief changelog

  • Validate and normalize data source keys before update and deletion.
  • Return HTTP 400 for missing or blank keys.
  • Return HTTP 404 when deleting an unknown data source.
  • Make data source deletion atomic and add regression tests.

Verifying this change

  • cd server && mvn -q -Dtest=SettingsControllerTest,SettingsServiceTest,InMemorySettingsRepositoryTest test
  • cd server && mvn -q test
  • cd server && mvn -q clean package -DskipTests

@lizhimins
lizhimins merged commit bd0e056 into apache:rocketmq-studio Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants