Skip to content

Comments

[ISSUE #273 ]Add .NET Client to RocketMQ #273#334

Closed
ClementIV wants to merge 7 commits intoapache:masterfrom
ClementIV:master
Closed

[ISSUE #273 ]Add .NET Client to RocketMQ #273#334
ClementIV wants to merge 7 commits intoapache:masterfrom
ClementIV:master

Conversation

@ClementIV
Copy link
Contributor

@ClementIV ClementIV commented Jul 21, 2019

What is the purpose of the change

Add .NET Client to RocketMQ

Brief changelog

  1. Refactoring code structure
  2. Publish the NuGet package
  3. Write some documents
    • readme.md
    • Quick Start
    • API Reference

Verifying this change

-[ISSUE #273 ] Add .NET Client to RocketMQ

Add .NET Client

  1. Refactoring code structure, see readme.md for more information.
  2. Build a local rocketmq test environment
  3. Connect Aliyun RocketMQ tested related APIs
  4. Create a new project to test the NuGet packagerocketmq-client-dotnet
  5. Write some documents
    • readme.md
    • Quick Start
    • API Reference

Unit Test

  1. Add unit test
  2. 43.22% coverage

@ClementIV ClementIV changed the title Add .NET Client to RocketMQ #273 [ISSUES #273 ]Add .NET Client to RocketMQ #273 Jul 21, 2019
@ClementIV ClementIV changed the title [ISSUES #273 ]Add .NET Client to RocketMQ #273 [ISSUE #273 ]Add .NET Client to RocketMQ #273 Jul 21, 2019
#region default Options

private HandleRef _handleRef;
private readonly string LogPath = Environment.CurrentDirectory.ToString() + "\\PullConsumer_log.txt";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Environment.CurrentDirectory 已经是 string 类型了。不用再调用 ToString() 方法
  • \\ 建议使用 System.IO.Path.DirectorySeparatorChar 代替。将来在 linux 上也不会有问题。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

public IPushConsumerBuilder SetPushConsumerGroupId(string groupId)
public MQPushConsumer(string groupId)
{

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多余的空行。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


public MQPushConsumer(string groupId, string nameServerAddress)
{

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多余的空行。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

public static extern int ReleasePullResult(CPullResult pullResult);

}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多余的空行

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

public const string RocketMQDriverDllName = "rocketmq-client-cpp.dll";
public const string RocketMQDriverDllName = "CClient\\rocketmq-client-cpp.dll";

public const string DiagnosticListenerName = "rocketmq-driver";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下四个常量这里面没有使用,如果不打算用,最好删除。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted

@netcore-jroger
Copy link
Contributor

现在的:rocketmq-client-dotnet/src/RocketMQ.NETClient/
建议改成: rocketmq-client-dotnet/src/RocketMQ.Client/

@ClementIV ClementIV closed this Nov 12, 2019
@John0King
Copy link

what happend ?

@vongosling
Copy link
Member

@duhenglucky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants