Skip to content

[ISSUE #573] (rocketmq-flume)Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer#576

Merged
zongtanghu merged 2 commits into
apache:masterfrom
Aaron-He:flume-dev
Jun 23, 2020
Merged

[ISSUE #573] (rocketmq-flume)Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer#576
zongtanghu merged 2 commits into
apache:masterfrom
Aaron-He:flume-dev

Conversation

@Aaron-He
Copy link
Copy Markdown
Contributor

@Aaron-He Aaron-He commented Jun 8, 2020

What is the purpose of the change

DefaultMQPullConsumer is deprecated after RMQ Version 4.6.0. A better implementation DefaultLitePullConsumer is recommend to use in the scenario of actively pulling messages. We can use it.

Brief changelog

Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer

Verifying this change

Yes

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Aaron-He Aaron-He changed the title [ISSUE #573](rocketmq-flume)Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer [ISSUE #573] (rocketmq-flume)Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer Jun 8, 2020
@Aaron-He Aaron-He requested a review from zongtanghu June 15, 2020 09:21
@zongtanghu zongtanghu merged commit e5d34ac into apache:master Jun 23, 2020
imaffe pushed a commit to imaffe/rocketmq-externals that referenced this pull request Jul 27, 2020
…ltLitePullConsumer (apache#576)

* (rocketmq-flume)Change to DefaultLitePullConsumer and Remove unnecessary lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[rocketmq-flume] DefaultMQPullConsumer is deprecated after RMQ Version 4.6.0

4 participants