Skip to content

[ISSUE #562] add triggerListener when removing connector configs#585

Merged
RongtongJin merged 2 commits into
apache:masterfrom
imaffe:affe-0621-issue562-triggerListener-after-remove
Jul 27, 2020
Merged

[ISSUE #562] add triggerListener when removing connector configs#585
RongtongJin merged 2 commits into
apache:masterfrom
imaffe:affe-0621-issue562-triggerListener-after-remove

Conversation

@imaffe
Copy link
Copy Markdown
Contributor

@imaffe imaffe commented Jun 21, 2020

What is the purpose of the change

  1. trigger listener after remove a connector

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@imaffe imaffe changed the title #562 add triggerListener [ISSUE #562]#562 add triggerListener Jun 21, 2020
</src_description>
</component>
<component name="NewModuleRootManager">
<component name="NewModuleRootManager" LANGUAGE_LEVEL="JDK_1_8">
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should put this file in .gitignore

@imaffe imaffe changed the title [ISSUE #562]#562 add triggerListener [ISSUE #562] add triggerListener when removing connector configs Jul 5, 2020
@RongtongJin RongtongJin merged commit a0c1adf into apache:master Jul 27, 2020
Dreaouth pushed a commit to Dreaouth/rocketmq-externals that referenced this pull request Jul 28, 2020
apache#585)

* apache#562 add triggerListener

* fix(connect-jms)  deleted .iml file
odbozhou pushed a commit that referenced this pull request Mar 1, 2022
* #562 add triggerListener

* fix(connect-jms)  deleted .iml file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants